Skip to content

Add missing zend_parse_parameters_none() checks #4796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add missing zend_parse_parameters_none() checks #4796

wants to merge 1 commit into from

Conversation

carusogabriel
Copy link
Contributor

No description provided.

@carusogabriel carusogabriel requested a review from cmb69 October 7, 2019 23:33
@carusogabriel carusogabriel changed the title Add missing zend_parse_parameters_none() checks for connection_*() Add zend_parse_parameters_none() checks for standard functions Oct 7, 2019
@carusogabriel carusogabriel changed the title Add zend_parse_parameters_none() checks for standard functions Add missing zend_parse_parameters_none() checks Oct 7, 2019
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@php-pulls php-pulls closed this in 9518155 Oct 8, 2019
@kocsismate
Copy link
Member

Can I ask you what the reason is that you didn't use the fast parameter parsing API? I am just asking this because I've just started to learn how the internals of php work, and it makes me wonder why so many functions still use the old method?

I know from the RFC that fast ZPP is for the most used functions, but my assumption is that even though the performance benefit would be negligible, having a uniform way of checking parameters could still worth the effort. What do you think?

If it makes sense to use fast ZPP in more places, then I'd love to help the PHP project by performing additional conversions.

@carusogabriel
Copy link
Contributor Author

@kocsismate Please see the discussion at #3041.

@kocsismate
Copy link
Member

@carusogabriel Thank you very much for the link to this insightful discussion :)

@carusogabriel carusogabriel deleted the chore/missing-zpp branch January 5, 2020 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants